Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(site): Do not require immutable parameters #6637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 17, 2023
Merged

fix(site): Do not require immutable parameters #6637

merged 2 commits into from
Mar 17, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma commented Mar 16, 2023 •
edited by mtojek
Loading

This PR fixes the following site bug:

Screenshot 2023-03-16 at 11 29 10

@BrunoQuaresma BrunoQuaresma requested a review from mtojek March 16, 2023 17:02
@BrunoQuaresma BrunoQuaresma self-assigned this Mar 16, 2023
@BrunoQuaresma BrunoQuaresma changed the title fix(site): Do not require mutable parameters fix(site): Do not require immutable parameters Mar 16, 2023
mtojek
mtojek approved these changes Mar 16, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mtojek mtojek self-requested a review March 17, 2023 08:26
mtojek
mtojek approved these changes Mar 17, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have just finished testing, and it is working now 👍 . I haven't spotted any bugs.

@BrunoQuaresma BrunoQuaresma merged commit 01a6af9 into main Mar 17, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/fix-update-dialog-form branch March 17, 2023 13:09
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtojek mtojek mtojek approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@BrunoQuaresma @mtojek