Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor(site): Group template permissions, settings and variables under a settings layout #6737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Mar 23, 2023

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma requested review from bpmct and a team March 22, 2023 17:49
@BrunoQuaresma BrunoQuaresma self-assigned this Mar 22, 2023
@BrunoQuaresma BrunoQuaresma requested review from rodrimaia and Kira-Pilot and removed request for a team March 22, 2023 17:50
Copy link
Contributor

@rodrimaia rodrimaia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@@ -183,19 +162,10 @@ export const templateVariablesMachine = createMachine(
},
{
services: {
getTemplate: ({ organizationId, templateName }) => {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this! :)

@BrunoQuaresma BrunoQuaresma merged commit 88e24db into main Mar 23, 2023
@BrunoQuaresma BrunoQuaresma deleted the bq/template-settings-refactor branch March 23, 2023 19:43
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consolidate template variables and settings
2 participants