Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(agent): Prevent loss of SSH PTY command output #6840

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

fix(agent): Prevent loss of SSH PTY command output #6840

wants to merge 1 commit into from

Conversation

mafredri
Copy link
Member

Non-ideal fix for PTY output loss because it always adds a delay of
100ms.

Completely fixes #6656

@mafredri
fix(agent): Prevent loss of SSH PTY command output
f4458d6 
Non-ideal fix for PTY output loss because it always adds a delay of
100ms.

Completely fixes #6656
@mafredri mafredri self-assigned this Mar 28, 2023
@mafredri mafredri mentioned this pull request Mar 29, 2023
Merged
mafredri added a commit that referenced this pull request Mar 29, 2023
@mafredri
fix(agent): Close stdin and stdout separately to fix pty output loss
010f111 
Fixes #6656
Closes #6840
mafredri added a commit that referenced this pull request Mar 29, 2023
@mafredri
fix(agent): Close stdin and stdout separately to fix pty output loss
40377be 
Fixes #6656
Closes #6840
mafredri added a commit that referenced this pull request Mar 29, 2023
@mafredri
fix(agent): Close stdin and stdout separately to fix pty output loss
197bedc 
Fixes #6656
Closes #6840
bpmct
bpmct reviewed Mar 29, 2023
View reviewed changes
Copy link
Member

@bpmct bpmct left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mafredri how do you suggest we move forward with this? I imagine this removes the last of the flakes with ssh PTY

@bpmct bpmct mentioned this pull request Mar 29, 2023
Closed
1 task
@mafredri
Copy link
Member Author

@bpmct #6862

mafredri added a commit that referenced this pull request Mar 29, 2023
@mafredri
fix(agent): Close stdin and stdout separately to fix pty output loss (#…
90d18dd 
…6862)

Fixes #6656
Closes #6840
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2023
@github-actions github-actions bot deleted the mafredri/fix-tty-output-never-lost branch September 29, 2023 00:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpmct bpmct bpmct left review comments

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Running commands over ssh -t periodically gives no output
2 participants
@mafredri @bpmct