Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat(site): display template's readme first on template page #6863

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Apr 3, 2023
Merged

feat(site): display template's readme first on template page #6863

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
6c45ca0
feat(site): display template's readme first on template page
rodrimaia Mar 29, 2023
7bef779
chore: prettier
rodrimaia Mar 29, 2023
650044f
move readme to a new docs tab
rodrimaia Mar 31, 2023
43675e0
test
rodrimaia Mar 31, 2023
0fcbbda
prettier
rodrimaia Apr 3, 2023
6e53534
Merge branch 'main' into move_readme_template_page
rodrimaia Apr 3, 2023
189c3a2
fix tests
rodrimaia Apr 3, 2023
25fabdb
prettier
rodrimaia Apr 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
fix tests
  • Loading branch information
@rodrimaia
rodrimaia committed Apr 3, 2023
commit 189c3a28deb6a1d490cdcda4a928dbafb84691ed
9 changes: 6 additions & 3 deletions site/src/pages/TemplatePage/TemplateDocsPage/TemplateDocsPage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,11 +1,13 @@
import { screen } from "@testing-library/react"
import { TemplateLayout } from "components/TemplateLayout/TemplateLayout"
import { ResizeObserver } from "resize-observer"
import { MockTemplate, renderWithAuth } from "testHelpers/renderHelpers"
import { renderWithAuth } from "testHelpers/renderHelpers"
import TemplateDocsPage from "./TemplateDocsPage"

jest.mock("remark-gfm", () => jest.fn())

const TEMPLATE_NAME = "coder-ts"

Object.defineProperty(window, "ResizeObserver", {
value: ResizeObserver,
})
Expand All @@ -16,15 +18,16 @@ const renderPage = () =>
<TemplateDocsPage />
</TemplateLayout>,
{
route: `/templates/${MockTemplate.id}/docs`,
route: `/templates/${TEMPLATE_NAME}/docs`,
path: "/templates/:template/docs",
},
)

const README_FILENAME = "readme.md"

describe("TemplateSummaryPage", () => {
it("shows the template readme", async () => {
renderPage()
await screen.findByText(MockTemplate.display_name)
await screen.findByTestId("markdown")
})
})
1 change: 0 additions & 1 deletion site/src/pages/TemplatePage/TemplateSummaryPage/TemplateSummaryPage.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,6 @@ describe("TemplateSummaryPage", () => {

renderPage()
await screen.findByText(MockTemplate.display_name)
screen.getByText(MockWorkspaceResource.name)
screen.queryAllByText(`${MockTemplateVersion.name}`).length
})
it("does not allow a member to delete a template", () => {
Expand Down