Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: make version.sh work in forks #6993

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 4, 2023
Merged

Conversation

deansheather
Copy link
Member

@deansheather deansheather commented Apr 4, 2023

version.sh doesn't work in forks since forking a repo doesn't copy tags by default. This makes version.sh fallback to 0.1.0 if there are no tags and the repo seems to be a fork.

Closes #4857

@deansheather deansheather requested a review from Emyrk April 4, 2023 01:03
@deansheather deansheather self-assigned this Apr 4, 2023
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@deansheather deansheather enabled auto-merge (squash) April 4, 2023 01:05
@deansheather deansheather merged commit 3cca30c into main Apr 4, 2023
@deansheather deansheather deleted the dean/fork-versionsh branch April 4, 2023 01:13
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Contributing guide: fatal: No names found, cannot describe anything
2 participants