Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: update example templates to use display_name #7001

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 17 commits into from
Apr 12, 2023
Merged

chore: update example templates to use display_name #7001

merged 17 commits into from
Apr 12, 2023

Conversation

matifali
Copy link
Member

@matifali matifali commented Apr 4, 2023 •
edited
Loading

This resolves #6978
I validated all the templates with terraform validate

@matifali matifali requested a review from bpmct April 4, 2023 11:13
@matifali matifali changed the title chore: add display_name to example templates chore: update example templates to use display_name Apr 4, 2023
@matifali matifali marked this pull request as ready for review April 4, 2023 11:25
@matifali matifali requested a review from mtojek April 4, 2023 12:14
@matifali matifali added the chore label Apr 4, 2023
mtojek
mtojek reviewed Apr 4, 2023
View reviewed changes
Copy link
Member

@mtojek mtojek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for PR! Most comments refer to using display_name as a description, and for that we have a separate property.

@matifali matifali mentioned this pull request Apr 7, 2023
Merged
@matifali matifali requested a review from mtojek April 7, 2023 08:58
@matifali
Copy link
Member Author

matifali commented Apr 7, 2023

@mtojek I have updated as per suggestions and moved the longer display_name fields to description where applicable

bpmct
bpmct approved these changes Apr 7, 2023
View reviewed changes
Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you change all casing to title case?

e.g.

  • Docker Image -> Docker image
  • Home Volume Size -> Home volume size

@bpmct bpmct enabled auto-merge (squash) April 7, 2023 19:30
@bpmct bpmct disabled auto-merge April 7, 2023 19:30
@matifali matifali requested a review from bpmct April 12, 2023 17:28
@bpmct bpmct merged commit 114d4aa into coder:main Apr 12, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 12, 2023
@matifali matifali deleted the update-example-templates branch April 14, 2023 11:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mtojek mtojek mtojek approved these changes

@bpmct bpmct bpmct approved these changes

Assignees

@matifali matifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

update examples to use display_name
3 participants
@matifali @mtojek @bpmct