Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: VSCode desktop connection #7120

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Apr 14, 2023
Merged

fix: VSCode desktop connection #7120

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
3a26ba4
fix: VSCode desktop connection
matifali Apr 13, 2023
abee3a3
add test
matifali Apr 14, 2023
8d1e62d
fix typo
matifali Apr 14, 2023
a27e0b3
update docs
matifali Apr 14, 2023
637b4cd
make fmt
matifali Apr 14, 2023
2f6cb95
chnage order of tests
matifali Apr 14, 2023
d13c1c3
WIP
matifali Apr 14, 2023
b10f240
WIP
matifali Apr 14, 2023
9021af2
WIP
matifali Apr 14, 2023
d8afe9b
fix logic to pass tests
matifali Apr 14, 2023
2e5639a
fix fix logic to pass tests
matifali Apr 14, 2023
4bae3e9
fix go brackets are weired
matifali Apr 14, 2023
8761402
WIP
matifali Apr 14, 2023
f18768b
fmt
matifali Apr 14, 2023
586e7cb
WIP
matifali Apr 14, 2023
ea7b289
WIP
matifali Apr 14, 2023
1c15caa
WIP
matifali Apr 14, 2023
3c03c20
WIP
matifali Apr 14, 2023
3a19877
WIP
matifali Apr 14, 2023
0885771
WIP
matifali Apr 14, 2023
2812de6
Merge branch 'coder:main' into vscode-path
matifali Apr 14, 2023
8e460ba
WIP
matifali Apr 14, 2023
7ef0c98
Update docs/templates/open-in-coder.md
matifali Apr 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
WIP
  • Loading branch information
@matifali
matifali committed Apr 14, 2023
commit 586e7cbafe5bb953695219b8fdb54ddb0dcbe2df
11 changes: 2 additions & 9 deletions agent/agent.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1406,20 +1406,13 @@ func expandDirectory(dir string) (string, error) {
return "", err
}
dir = filepath.Join(home, dir[1:])

} else if !filepath.IsAbs(dir) {
// If the directory is not absolute, we assume it is relative to the
// user's home directory.
}
if !filepath.IsAbs(dir) {
home, err := userHomeDir()
if err != nil {
return "", err
}
dir = filepath.Join(home, dir)

} else {
// If the directory is absolute, we assume it is an absolute path.
// We do not check if the directory exists.
return dir, nil
}
return os.ExpandEnv(dir), nil
}