fix(cli): Fix postgres TDE failing version check #7203
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
|
I have read the CLA Document and I hereby sign the CLA |
cdrcommunity
added a commit
to coder/cla
that referenced
this pull request
Apr 19, 2023
kylecarbs
approved these changes
Apr 19, 2023
coadler
approved these changes
Apr 19, 2023
coadler
reviewed
Apr 19, 2023
|
Thanks @MTschirnich! |
|
Hello @coadler, I am not sure what the exact nature of the error in the test-go for Ubuntu is. Do you have an idea? |
|
Just looks like a flake. I'll rerun and merge 🙂 |
|
Thanks 😄 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I am running postgres 13 TDE and ran into the issue coder reporting the version is not v13 or higher.
After a bit of investigating I noticed coder uses "SHOW server_version".
Unfortunately the postgres TDE build reports it version other than a normal postgres build.
Postgres 13 TDE: "13.10_TDE_1.0.5 (Ubuntu.....)"
Postgres 12: "12.13 (Ubuntu...)"
In cli/server.go the version check splits at the space and proceeds to compare it with semver, which does not seem to like the additional content.
I addressed this by changing the server_version to server_version_num, as this is a number and the TDE information is not present. This also simplifies the comparison of the versions.