Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: Add comment explaining why testpackage is enabled #774

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 31, 2022
Merged

Conversation

kylecarbs
Copy link
Member

A discussion (linked below) was had that touched on why this linter
is enabled. To avoid losing that history, adding the comment inline with
our linting rules can avoid duplicating this discussion!

#741 (comment)

A discussion (linked below) was had that touched on why this linter
is enabled. To avoid losing that history, adding the comment inline with
our linting rules can avoid duplicating this discussion!

#741 (comment)
@kylecarbs kylecarbs requested review from Emyrk and f0ssel March 31, 2022 16:49
@kylecarbs kylecarbs self-assigned this Mar 31, 2022
@codecov
Copy link

codecov bot commented Mar 31, 2022

Codecov Report

Merging #774 (8f697af) into main (bb6c12d) will decrease coverage by 0.06%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #774      +/-   ##
==========================================
- Coverage   63.91%   63.84%   -0.07%     
==========================================
  Files         199      199              
  Lines       11826    11826              
  Branches       87       87              
==========================================
- Hits         7558     7550       -8     
- Misses       3442     3449       +7     
- Partials      826      827       +1     
Flag Coverage Δ
unittest-go- 62.97% <ø> (-0.19%) ⬇️
unittest-go-macos-latest 58.78% <ø> (+<0.01%) ⬆️
unittest-go-ubuntu-latest 61.79% <ø> (+0.16%) ⬆️
unittest-go-windows-2022 58.03% <ø> (-0.02%) ⬇️
unittest-js 62.63% <ø> (ø)
Impacted Files Coverage Δ
provisionersdk/transport.go 78.72% <0.00%> (-6.39%) ⬇️
cli/cliui/agent.go 77.19% <0.00%> (-5.27%) ⬇️
coderd/workspaceresources.go 54.87% <0.00%> (-2.85%) ⬇️
peer/channel.go 83.04% <0.00%> (-0.59%) ⬇️
peerbroker/proxy.go 57.55% <0.00%> (-0.59%) ⬇️
coderd/provisionerdaemons.go 60.03% <0.00%> (-0.51%) ⬇️
peer/conn.go 78.17% <0.00%> (ø)
provisionerd/provisionerd.go 79.14% <0.00%> (ø)
provisioner/echo/serve.go 56.80% <0.00%> (+2.39%) ⬆️
peerbroker/dial.go 83.60% <0.00%> (+6.55%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update bb6c12d...8f697af. Read the comment docs.

Copy link
Contributor

@f0ssel f0ssel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

love it

@kylecarbs kylecarbs merged commit 50f2fca into main Mar 31, 2022
@kylecarbs kylecarbs deleted the testpkg branch March 31, 2022 17:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants