Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: add proxy health interval flag/env config #7919

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 8, 2023

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Jun 8, 2023

Allows manually changing the proxy health interval

--proxy-health-interval=10m

@Emyrk Emyrk changed the title chore: plumbing for proxy health interval from flag/env chore: add proxy health interval flag/env config Jun 8, 2023
Copy link
Member

@johnstcn johnstcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@@ -193,6 +193,10 @@ backed by Tailscale and WireGuard.
The maximum lifetime duration users can specify when creating an API
token.

--proxy-health-interval duration, $CODER_PROXY_HEALTH_INTERVAL (default: 1m0s)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be health-check?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Felt long to say health check and figured health-interval was descriptive enough

@Emyrk Emyrk merged commit a4cc883 into main Jun 8, 2023
@Emyrk Emyrk deleted the stevenmasley/proxy_health_interval branch June 8, 2023 17:58
@github-actions github-actions bot locked and limited conversation to collaborators Jun 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants