Thanks to visit codestin.com
Credit goes to github.com

Skip to content

test: add golden files to enterprise cli #7924

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Jun 9, 2023

Conversation

Emyrk
Copy link
Member

@Emyrk Emyrk commented Jun 8, 2023

Fixes #6766

// using golden files.
//
//nolint:tparallel,paralleltest
func TestCommandHelp(t *testing.T, cmds []*clibase.Cmd, cases []CommandHelpCase) {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just moved this function so it can be reused.

@ammario
Copy link
Member

ammario commented Jun 8, 2023

Big thank you!

@Emyrk Emyrk changed the title Stevenmasley/enterprise golden cli chore: add golden files to enterprise cli Jun 8, 2023
@Emyrk Emyrk requested a review from mafredri June 8, 2023 20:21
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A bunch of the golden files seem to be for the wrong command 🤔

@Emyrk Emyrk requested a review from mafredri June 9, 2023 13:46
@mafredri mafredri changed the title chore: add golden files to enterprise cli test: add golden files to enterprise cli Jun 9, 2023
@Emyrk Emyrk merged commit 0652063 into main Jun 9, 2023
@Emyrk Emyrk deleted the stevenmasley/enterprise_golden_cli branch June 9, 2023 16:35
@github-actions github-actions bot locked and limited conversation to collaborators Jun 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

cli: generate golden files in the enterprise package
3 participants