Thanks to visit codestin.com
Credit goes to github.com

Skip to content

docs: document CORS behavior between forwarded apps #7944

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 12, 2023
Merged

docs: document CORS behavior between forwarded apps #7944

merged 3 commits into from
Jun 12, 2023

Conversation

code-asher
Copy link
Member

@code-asher code-asher commented Jun 9, 2023 •
edited
Loading

Closes #7940

@code-asher code-asher marked this pull request as ready for review June 9, 2023 20:34
@code-asher code-asher requested review from Emyrk and bpmct June 9, 2023 20:34
@code-asher
Copy link
Member Author

code-asher commented Jun 9, 2023 •
edited
Loading

Actually I think I should move it under the dashboard section since it does not apply to the other forwarding methods. Or make mention of it only applying to the dashboard. added a note and moved it

@code-asher code-asher force-pushed the asher/cors-docs branch 2 times, most recently from af4dba0 to a7ef1c3 Compare June 9, 2023 20:53
@code-asher
docs: move CORS documentation under dashboard section
9a80fe3 
None of this applies to ports forwarded in other ways.
bpmct
bpmct approved these changes Jun 10, 2023
View reviewed changes
Copy link
Member

@bpmct bpmct left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is very clear and easy to digest, thanks @code-asher @Emyrk.

The table definitely helps me understand what types of requests are allowed

@bpmct bpmct enabled auto-merge (squash) June 12, 2023 20:54
@bpmct bpmct merged commit 4a0ac13 into main Jun 12, 2023
@bpmct bpmct deleted the asher/cors-docs branch June 12, 2023 20:59
@github-actions github-actions bot locked and limited conversation to collaborators Jun 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bpmct bpmct bpmct approved these changes

@Emyrk Emyrk Awaiting requested review from Emyrk

Assignees

@code-asher code-asher

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

docs: explain how Coder handles CORS in subdomain apps
2 participants
@code-asher @bpmct