fix(coderd/database): improve pubsub closure and context cancellation #7993
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3c1b45c to
2b1fc55
Compare
2b1fc55 to
118fcee
Compare
kylecarbs
approved these changes
Jun 13, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR improves closure of
Pubsubso that context cancellation is propagated to listeners and publish.Since Pubsub has a
Closemethod, we were incorrectly keeping a reference to the callingctxso that it had side-effects afterNewPubsubreturned. This is bad because we mustn't have two ways to close a thing, especially when both leave the service half-open/half-closed). This has been fixed via internal context handling forPubsub.