Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: add front-end fixes for minor workspace action bugs #8252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 30, 2023

Conversation

Kira-Pilot
Copy link
Member

Some fixes included in this PR are:

  • Copy fix on inactivity_ttl field in the template schedule settings page
  • We now disable the locked_ttl field in the template schedule settings page if inactivity_ttl is not set
  • We now disable all template schedule form fields upon submission
  • Previously, the warning dialog shown if workspaces will be immediately marked for deletion was not scoped to the template on which inactivity_ttl was being set - we have added that filter
  • Previously, the warning dialog was not handling pluralization correctly; now it does
  • We now only show the warning dialog if locked_ttl is set; however, more work will have to be done here once the BE logic for locked workspaces is in place
  • Fixed a bug where the ImpendingDeletionBanner component appeared only on certain workspace table pages; now it shows constantly (unless dismissed)

@Kira-Pilot Kira-Pilot merged commit c569528 into main Jun 30, 2023
@Kira-Pilot Kira-Pilot deleted the wa-cleanup/kira-pilot branch June 30, 2023 13:45
@github-actions github-actions bot locked and limited conversation to collaborators Jun 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants