fix(agent/usershell): check shell on darwin via dscl #8366
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
c48681e to
48e1cb4
Compare
48e1cb4 to
39a9bab
Compare
johnstcn
approved these changes
Jul 7, 2023
kylecarbs
approved these changes
Jul 11, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes it so that we check the user configured shell via
dsclon macOS. This should be more reliable than expecting the presence of the SHELL env variable. This requires a valid user to exist at/Users/usernamethough (which is usually the case with all things macOS).Thought: We might want to introduce some fallbacks to this in the future. macOS could fallback to
/bin/zshand Linux to/bin/sh, for instance.Fixes https://github.com/coder/v2-customers/issues/224