Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(coderd): pass oauth configs to site #8390

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 10, 2023
Merged

fix(coderd): pass oauth configs to site #8390

merged 2 commits into from
Jul 10, 2023

Conversation

mafredri
Copy link
Member

Fixes #8351

@mafredri mafredri requested a review from Emyrk July 10, 2023 11:54
mafredri
mafredri commented Jul 10, 2023
View reviewed changes
site/site.go
DB: h.opts.Database,
Optional: true,
DB: h.opts.Database,
OAuth2Configs: h.opts.OAuth2Configs,
Copy link
Member Author

@mafredri mafredri Jul 10, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we pass other extract api key configs, like DisableSessionExpiryRefresh, too?

Edit: We also don't seem to be utilizing e.g. DisableSessionExpiryRefresh in enterprise/coderd, is this a bug?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/ping @deansheather (ref: #5976)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah we should be setting that flag everywhere we use it, so this is definitely a bug.

For this specific case though, we can just set it to true because it doesn't matter if loading the frontend doesn't refresh the token (because the frontend will make API requests after loading the page).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @deansheather, added the always true and an accompanying comment.

This was referenced Jul 10, 2023
Closed
Merged
Emyrk
Emyrk approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@Emyrk Emyrk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is such a good find @mafredri 👍

@mafredri mafredri merged commit 90a3deb into main Jul 10, 2023
@mafredri mafredri deleted the mafredri/fix-coderd-site-oauth-configs branch July 10, 2023 14:23
@github-actions github-actions bot locked and limited conversation to collaborators Jul 10, 2023
@bpmct
Copy link
Member

bpmct commented Jul 10, 2023

Hi folks! This has been fixed and is in the v0.26.0 release.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deansheather deansheather deansheather left review comments

@Emyrk Emyrk Emyrk approved these changes

Assignees

@mafredri mafredri

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Occasional "panic serving http request"
4 participants
@mafredri @bpmct @Emyrk @deansheather