Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: use names for all GitHub actions steps and use sqlc setup action #8495

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 13, 2023
Merged

chore: use names for all GitHub actions steps and use sqlc setup action #8495

merged 7 commits into from
Jul 13, 2023

Conversation

matifali
Copy link
Member

@matifali matifali commented Jul 13, 2023 •
edited
Loading

  1. Use the officially available sqlc-setup action in ci
    https://docs.sqlc.dev/en/v1.19.0/howto/ci-cd.html#github-workflows
  2. Name all steps in jobs

@matifali matifali self-assigned this Jul 13, 2023
cdr-bot[bot]
cdr-bot bot previously approved these changes Jul 13, 2023
View reviewed changes
Copy link

@cdr-bot cdr-bot bot left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is no longer a hotfix.

  • ✅ Base is main
  • ✅ Has hotfix label
  • ✅ Head is from coder/coder
  • ❌ Less than 100 lines

@matifali matifali enabled auto-merge (squash) July 13, 2023 13:03
@matifali matifali disabled auto-merge July 13, 2023 13:13
@cdr-bot cdr-bot bot dismissed their stale review July 13, 2023 13:18

This PR is no longer a hotfix.

@matifali matifali added hotfix and removed hotfix labels Jul 13, 2023
@matifali matifali requested review from coadler and ammario July 13, 2023 13:21
@matifali matifali changed the title chore: use sqlc setup action refactor: refactor ci Jul 13, 2023
ammario
ammario reviewed Jul 13, 2023
View reviewed changes
Copy link
Member

@ammario ammario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kylecarbs -- what's the status of your Nix work on CI?

@matifali
Copy link
Member Author

@ammario this is mostly a cosmetic change and doesn't change any behavior.

ammario
ammario approved these changes Jul 13, 2023
View reviewed changes
Copy link
Member

@ammario ammario left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@matifali I see. The current PR title suggests a far more expansive refactor, so I think it should be changed before merge.

@matifali matifali changed the title refactor: refactor ci chore: name all steps in ci Jul 13, 2023
@matifali matifali changed the title chore: name all steps in ci chore: use names for all GitHub actions steps and use sqlc setup action Jul 13, 2023
@matifali matifali merged commit be10138 into main Jul 13, 2023
@matifali matifali deleted the matifali- branch July 13, 2023 19:46
@github-actions github-actions bot locked and limited conversation to collaborators Jul 13, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@ammario ammario ammario approved these changes

@cdr-bot cdr-bot[bot] cdr-bot[bot] left review comments

@coadler coadler Awaiting requested review from coadler

Assignees

@matifali matifali

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@matifali @ammario