-
Notifications
You must be signed in to change notification settings - Fork 881
feat(cli): check if dotfiles install script is executable #8588
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
CLA Assistant Lite bot All contributors have signed the CLA ✍️ ✅ |
I have read the CLA Document and I hereby sign the CLA |
b4d8e20
to
1d9c0f0
Compare
Thanks for the contribution! I do wonder whether or not we should do this, though. This will introduce a local change into the repo being checked out (git tracks executable bit on files). Another solution would be to Perhaps it would be safer to check the executable bit and print a pretty error explaining how to fix it? We could also run scripts via interpreter like |
Hmm.. Let me look into it |
Yes, you are correct in that case. So, I found this on StackOverflow. Shall I set a git config, so that such changes are ignored, for the dotfiles cloned repo?
Yes, can be done too. I am unable to choose which would be a better solution. |
Yeah on second thoughts, 2nd solution would be better. Check for exec bits, and notify user about the same. I am changing this, and pushing |
@mafredri Can you review it! |
Co-authored-by: Mathias Fredriksson <[email protected]>
I will also try to update docs. |
@mafredri I have added to docs about the same |
Co-authored-by: Muhammad Atif Ali <[email protected]>
Added all suggested changes. |
Co-authored-by: Muhammad Atif Ali <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I may have had some grammar nits, but all in all, excellent work! Thanks a lot for your contribution and going the extra mile!
Co-authored-by: Mathias Fredriksson <[email protected]>
Co-authored-by: Mathias Fredriksson <[email protected]>
Co-authored-by: Mathias Fredriksson <[email protected]>
Co-authored-by: Mathias Fredriksson <[email protected]>
Co-authored-by: Mathias Fredriksson <[email protected]>
Co-authored-by: Mathias Fredriksson <[email protected]>
Problem Statement
So I was having an issue regarding the installation of dotfiles. Everything was working fine until an install script was executed. This install script was installing system dependencies and using sudo commands. Hence, I was getting
permission denied
.Solution
I added a code snippet just before the scripts were executed.
PS: Sorry, I didn't create an Issue first.