Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: replace cloudflare dev tunnel with frp #867

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Apr 14, 2022
Merged

chore: replace cloudflare dev tunnel with frp #867

merged 6 commits into from
Apr 14, 2022

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Apr 4, 2022 •
edited
Loading

Resolves #858
Resolves #632

@coadler coadler self-assigned this Apr 4, 2022
@coadler coadler force-pushed the colin/frp-tunnel branch from 7b9399e to 6f74e30 Compare April 4, 2022 21:13
@codecov
Copy link

codecov bot commented Apr 4, 2022 •
edited
Loading

Codecov Report

Merging #867 (8d8e9f2) into main (300c6d0) will increase coverage by 0.39%.
The diff coverage is 70.66%.

@@            Coverage Diff             @@
##             main     #867      +/-   ##
==========================================
+ Coverage   66.42%   66.82%   +0.39%     
==========================================
  Files         247      251       +4     
  Lines       14635    14890     +255     
  Branches      131      131              
==========================================
+ Hits         9722     9950     +228     
- Misses       3932     3946      +14     
- Partials      981      994      +13
Flag Coverage Δ
unittest-go-macos-latest 53.54% <8.00%> (-0.16%) ⬇️
unittest-go-postgres- 66.76% <70.66%> (+0.42%) ⬆️
unittest-go-ubuntu-latest 56.13% <8.00%> (-0.28%) ⬇️
unittest-go-windows-2022 53.06% <8.00%> (?)
unittest-js 61.24% <ø> (ø)
Impacted Files Coverage Δ
cli/start.go 63.51% <37.50%> (-0.63%) ⬇️
coderd/devtunnel/tunnel.go 79.66% <79.66%> (ø)
provisionersdk/serve.go 35.13% <0.00%> (-8.11%) ⬇️
peerbroker/dial.go 77.04% <0.00%> (-6.56%) ⬇️
peer/channel.go 83.23% <0.00%> (-0.58%) ⬇️
provisionerd/provisionerd.go 81.17% <0.00%> (ø)
pty/start_windows.go 66.95% <0.00%> (ø)
pty/pty_windows.go 68.25% <0.00%> (ø)
agent/usershell/usershell_windows.go 83.33% <0.00%> (ø)
coderd/database/queries.sql.go 84.07% <0.00%> (+0.41%) ⬆️
... and 7 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 300c6d0...8d8e9f2. Read the comment docs.

@kylecarbs
Copy link
Member

I poorly named the tunnel package when creating it. I'd propose we call this devtunnel instead for clarity. Thoughts?

@coadler coadler force-pushed the colin/frp-tunnel branch from 6f74e30 to 16b0119 Compare April 9, 2022 03:17
kylecarbs
kylecarbs reviewed Apr 9, 2022
View reviewed changes
coderd/devtunnel/tunnel.go
},
},
DomainConf: frpconfig.DomainConf{
SubDomain: subdomain,
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we whitelist valid subdomains on the frp side? This isn't high priority, but it'd be unfortunate for someone to phish with official.coder.app or some jank.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

They'd only be able to take x.tunnel.coder.app domains, which isn't really any different than devurls right? It is unfortunate that we can't pick this server-side though.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, it's not that big of a dealio

@coadler coadler marked this pull request as ready for review April 9, 2022 18:23
@coadler coadler requested a review from kylecarbs April 9, 2022 18:23
kylecarbs
kylecarbs approved these changes Apr 9, 2022
View reviewed changes
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comments, nothing big. This is awesome!

@coadler coadler requested a review from kylecarbs April 13, 2022 22:18
kylecarbs
kylecarbs approved these changes Apr 14, 2022
View reviewed changes
@kylecarbs
Copy link
Member

Forgot to click submit on my review from a while ago 🤦

@coadler coadler merged commit fed02cd into main Apr 14, 2022
@coadler coadler deleted the colin/frp-tunnel branch April 14, 2022 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kylecarbs kylecarbs kylecarbs approved these changes

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Replace Cloudflare tunneling with https://github.com/fatedier/frp CloudFlare tunnel sometimes breaks
2 participants
@coadler @kylecarbs