docs: add PR template #873
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsjoeio
commented
Apr 4, 2022
.github/pull_request_template.md
Outdated
|
|
||
| ## Checklist | ||
|
|
||
| - [ ] added a test |
There was a problem hiding this comment.
I know we care about testing so I figure having this checkbox is a gentle reminder that we should continually add tests for our code.
Codecov Report
@@ Coverage Diff @@
## main #873 +/- ##
==========================================
- Coverage 65.60% 65.51% -0.10%
==========================================
Files 213 216 +3
Lines 13650 13733 +83
Branches 103 103
==========================================
+ Hits 8955 8997 +42
- Misses 3782 3809 +27
- Partials 913 927 +14
Continue to review full report at Codecov.
|
|
@jsjoeio something is really wrong with the coverage numbers... I shall investigate! |
4baea23 to
b5acb9f
Compare
|
bump @kylecarbs |
kylecarbs
approved these changes
Apr 7, 2022
presleyp
reviewed
Apr 7, 2022
presleyp
reviewed
Apr 7, 2022
b5acb9f to
a108ce8
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a PR template which will show up when you create a new template. I figure we can keep it light for now and add more as needed. I imagine if we start to get a lot of community contributions, we may want to expand this.
Fixes #652