Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore(site): organize imports #876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 5, 2022
Merged

Conversation

greyscaled
Copy link
Contributor

This was an item I meant to get to in gap week, but ran out of steam for. Parity with v1.

@greyscaled greyscaled self-assigned this Apr 5, 2022
@greyscaled greyscaled requested a review from a team as a code owner April 5, 2022 07:51
@greyscaled greyscaled added typescript/js site Area: frontend dashboard labels Apr 5, 2022
@greyscaled greyscaled added this to the V2 Beta milestone Apr 5, 2022
@codecov
Copy link

codecov bot commented Apr 5, 2022

Codecov Report

Merging #876 (ea75708) into main (63916b6) will decrease coverage by 0.55%.
The diff coverage is 56.25%.

@@            Coverage Diff             @@
##             main     #876      +/-   ##
==========================================
- Coverage   66.27%   65.72%   -0.56%     
==========================================
  Files         205      205              
  Lines       13309    13309              
  Branches       87       87              
==========================================
- Hits         8821     8747      -74     
- Misses       3602     3663      +61     
- Partials      886      899      +13     
Flag Coverage Δ
unittest-go- 65.19% <ø> (-0.71%) ⬇️
unittest-go-macos-latest 52.54% <ø> (-0.24%) ⬇️
unittest-go-ubuntu-latest 55.23% <ø> (-0.26%) ⬇️
unittest-go-windows-2022 51.94% <ø> (ø)
unittest-js 62.36% <56.25%> (ø)
Impacted Files Coverage Δ
site/src/AppRouter.tsx 0.00% <0.00%> (ø)
site/src/Main.tsx 0.00% <0.00%> (ø)
site/src/app.tsx 0.00% <0.00%> (ø)
site/src/components/CodeExample/CodeExample.tsx 100.00% <ø> (ø)
site/src/components/Form/FormDropdownField.tsx 91.66% <ø> (ø)
site/src/components/Form/FormTextField.tsx 59.37% <ø> (ø)
site/src/components/Navbar/index.tsx 0.00% <0.00%> (ø)
site/src/components/Page/index.tsx 0.00% <0.00%> (ø)
site/src/components/User/UserProfileCard.tsx 75.00% <ø> (ø)
site/src/pages/404.tsx 0.00% <0.00%> (ø)
... and 35 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 63916b6...ea75708. Read the comment docs.

@kylecarbs
Copy link
Member

Can we remove the frontend label in favor of typescript/js? It's a bit ambiguous to me right now.

@greyscaled greyscaled removed the site Area: frontend dashboard label Apr 5, 2022
@greyscaled greyscaled merged commit c0a9eac into main Apr 5, 2022
@greyscaled greyscaled deleted the vapurrmaid/organize-ts-imports branch April 5, 2022 14:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants