coderd: autostart: codersdk, http api, database plumbing #879
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## main #879 +/- ##
==========================================
+ Coverage 65.77% 65.98% +0.21%
==========================================
Files 216 216
Lines 13734 13834 +100
Branches 103 103
==========================================
+ Hits 9033 9129 +96
Misses 3782 3782
- Partials 919 923 +4
Continue to review full report at Codecov.
|
greyscaled
approved these changes
Apr 5, 2022
coderd/database/migrations/000005_workspace_autostartstop.down.sql
Outdated
Show resolved
Hide resolved
coderd/database/migrations/000005_workspace_autostartstop.up.sql
Outdated
Show resolved
Hide resolved
kylecarbs
reviewed
Apr 6, 2022
coderd/workspaces_test.go
Outdated
| ) | ||
|
|
||
| err := client.UpdateWorkspaceAutostart(ctx, wsid, req) | ||
| require.EqualError(t, err, fmt.Sprintf("status code 404: workspace %q does not exist", wsid), "unexpected error") |
There was a problem hiding this comment.
nit: We could assert to codersdk.Error here to check the status code!
There was a problem hiding this comment.
FYI I ended up needing to squelch a linter error when trying to use errors.As on codersdk.Error.
This is the sort of thing I ended up with: https://go.dev/play/p/NHTmnYWan6g
- add unit tests to and from DST - ensure expected interval between autostarts
…/ UpdateWorkspaceAutostart
a17d3a1 to
316501d
Compare
This was referenced Apr 7, 2022
greyscaled
added a commit
that referenced
this pull request
Apr 13, 2022
Summary: This adds the client-side implementation to match the types introduced in #879 and #844 as well as a card in the Workspaces page to present workspace the data. Details: * Added a convenient line break in the example schedule.Weekly * Added missing `json:""` annotations in codersdk/workspaces.go * Installed cronstrue for displaying human-friendly cron strings * Adjusted/Added client-side types to match codersdk/workspaces.go * Added new component WorkspaceSchedule.tsx Next Steps: The WorkspaceSchedule.tsx card only presents data (on purpose). In order to make it PUT/modify data, a few changes will be made: - a form for updating workspace schedule will be created - the form will wrapped in a dialog or modal - the WorkspaceSchedule card will have a way of opening the modal which will likely be generalized up to WorkspaceSection.tsx Impact: This is user-facing This does not fully resolve either #274 or #275 (I may further decompose that work to reflect reality and keep things in small deliverable increments), but adds significant progress towards both.
greyscaled
added a commit
that referenced
this pull request
Apr 14, 2022
Summary: This adds the client-side implementation to match the types introduced in #879 and #844 as well as a card in the Workspaces page to present workspace the data. Details: * Added a convenient line break in the example schedule.Weekly * Added missing `json:""` annotations in codersdk/workspaces.go * Installed cronstrue for displaying human-friendly cron strings * Adjusted/Added client-side types to match codersdk/workspaces.go * Added new component WorkspaceSchedule.tsx Next Steps: The WorkspaceSchedule.tsx card only presents data (on purpose). In order to make it PUT/modify data, a few changes will be made: - a form for updating workspace schedule will be created - the form will wrapped in a dialog or modal - the WorkspaceSchedule card will have a way of opening the modal which will likely be generalized up to WorkspaceSection.tsx Impact: This is user-facing This does not fully resolve either #274 or #275 (I may further decompose that work to reflect reality and keep things in small deliverable increments), but adds significant progress towards both.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
putWorkspaceAutostartUpdateWorkspaceAutostartmethod🌮 to @vapurrmaid on the help with TDD!
NOTE: I also added the autostop-related database stuff before it was deemed better to submit smaller more integrated PRs. If this is a blocker, I can remove it from this PR and add it in the next. But it will likely be used Very Soon.
ALSO NOTE: I'm not using "fixes" here because the issues I opened are "horizontally" aligned, and not "vertically".