Thanks to visit codestin.com
Credit goes to github.com

Skip to content

feat: Add preferences pages #893

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 11 commits into from
Apr 7, 2022
Merged

feat: Add preferences pages #893

merged 11 commits into from
Apr 7, 2022

Conversation

BrunoQuaresma
Copy link
Collaborator

@BrunoQuaresma BrunoQuaresma commented Apr 6, 2022 •
edited
Loading

  • Rename Panel to TabPanel to make it clear it is a "tabbed" panel
  • Move Sidebar to TabPanel/TabSidebar since it is only used inside of TabPanel
  • Updated sidebar to use NavLink instead of onClick events

Closes #746

@BrunoQuaresma BrunoQuaresma requested a review from a team as a code owner April 6, 2022 19:10
@BrunoQuaresma
Copy link
Collaborator Author

BrunoQuaresma commented Apr 6, 2022 •
edited
Loading

@presleyp this may impact your work with the admin pages. Please, let me know if it breaks anything for you.

@BrunoQuaresma BrunoQuaresma self-assigned this Apr 6, 2022
@codecov
Copy link

codecov bot commented Apr 6, 2022 •
edited
Loading

Codecov Report

Merging #893 (86a1d7a) into main (90388a3) will increase coverage by 0.15%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #893      +/-   ##
==========================================
+ Coverage   65.73%   65.88%   +0.15%     
==========================================
  Files         218      222       +4     
  Lines       13849    13875      +26     
  Branches      103      103              
==========================================
+ Hits         9103     9142      +39     
+ Misses       3814     3811       -3     
+ Partials      932      922      -10
Flag Coverage Δ
unittest-go-macos-latest 52.92% <ø> (+0.02%) ⬆️
unittest-go-postgres- 65.83% <ø> (+0.40%) ⬆️
unittest-go-ubuntu-latest 55.30% <ø> (-0.12%) ⬇️
unittest-go-windows-2022 52.18% <ø> (+0.01%) ⬆️
unittest-js 57.59% <0.00%> (-1.51%) ⬇️
Impacted Files Coverage Δ
site/src/AppRouter.tsx 0.00% <0.00%> (ø)
site/src/components/Preferences/Layout.tsx 0.00% <0.00%> (ø)
site/src/components/TabPanel/TabSidebar.tsx 0.00% <0.00%> (ø)
site/src/components/TabPanel/index.tsx 0.00% <0.00%> (ø)
site/src/pages/preferences/account.tsx 0.00% <0.00%> (ø)
site/src/pages/preferences/linked-accounts.tsx 0.00% <0.00%> (ø)
site/src/pages/preferences/security.tsx 0.00% <0.00%> (ø)
site/src/pages/preferences/ssh-keys.tsx 0.00% <0.00%> (ø)
pty/start_other.go 64.70% <0.00%> (-23.53%) ⬇️
provisionerd/provisionerd.go 80.46% <0.00%> (-0.59%) ⬇️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 90388a3...86a1d7a. Read the comment docs.

presleyp
presleyp suggested changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@presleyp presleyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Can you take all the user-facing strings and put them in Language objects? There's an example in the SignInForm I believe.

greyscaled
greyscaled suggested changes Apr 6, 2022
View reviewed changes
Copy link
Contributor

@greyscaled greyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge latest main into this branch so that we get the Chromatic workflow to run

greyscaled
greyscaled reviewed Apr 7, 2022
View reviewed changes
Copy link
Contributor

@greyscaled greyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you merge latest mainline again --> want to have chromatic rerun on this one and it will error if your branch is behind #910

greyscaled
greyscaled reviewed Apr 7, 2022
View reviewed changes
Copy link
Contributor

@greyscaled greyscaled left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last set of changes, everything looks great otherwise!

@BrunoQuaresma BrunoQuaresma merged commit 75ef1f4 into main Apr 7, 2022
@BrunoQuaresma BrunoQuaresma deleted the bq/preferences-page branch April 7, 2022 19:44
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@presleyp presleyp presleyp approved these changes

@greyscaled greyscaled greyscaled approved these changes

Assignees

@BrunoQuaresma BrunoQuaresma

Labels
None yet
Projects
None yet
Milestone
V2 Beta
Development

Successfully merging this pull request may close these issues.

User Preferences page
4 participants
@BrunoQuaresma @presleyp @greyscaled @misskniss