Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: remove CodeCov annotations #928

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 8, 2022
Merged

Conversation

presleyp
Copy link
Contributor

@presleyp presleyp commented Apr 8, 2022

Trying to remove CodeCov annotations as per https://docs.codecov.com/docs/github-checks#disabling-github-checks-patch-annotations-via-yaml

The yaml didn't validate but it seemed to get caught on stuff after the addition.

@presleyp presleyp self-assigned this Apr 8, 2022
@presleyp presleyp requested review from jsjoeio and kylecarbs April 8, 2022 15:41
@presleyp presleyp changed the title Remove annotations/presleyp chore: remove CodeCov annotations Apr 8, 2022
Copy link
Member

@kylecarbs kylecarbs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. Those annotations hurt the readability of a PR!

@codecov
Copy link

codecov bot commented Apr 8, 2022

Codecov Report

Merging #928 (c5f5c76) into main (94ab6f3) will increase coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #928      +/-   ##
==========================================
+ Coverage   65.75%   65.80%   +0.05%     
==========================================
  Files         226      226              
  Lines       13998    13998              
  Branches      105      105              
==========================================
+ Hits         9204     9211       +7     
+ Misses       3854     3851       -3     
+ Partials      940      936       -4     
Flag Coverage Δ
unittest-go-macos-latest 52.71% <ø> (-0.22%) ⬇️
unittest-go-postgres- 65.75% <ø> (+0.26%) ⬆️
unittest-go-ubuntu-latest 55.34% <ø> (-0.11%) ⬇️
unittest-go-windows-2022 52.22% <ø> (-0.04%) ⬇️
unittest-js 58.25% <ø> (ø)
Impacted Files Coverage Δ
peerbroker/dial.go 77.04% <0.00%> (-6.56%) ⬇️
peer/conn.go 77.66% <0.00%> (-4.32%) ⬇️
provisionerd/provisionerd.go 79.14% <0.00%> (-0.59%) ⬇️
provisioner/echo/serve.go 56.80% <0.00%> (ø)
coderd/database/queries.sql.go 84.19% <0.00%> (+0.43%) ⬆️
peer/channel.go 83.62% <0.00%> (+0.58%) ⬆️
coderd/provisionerdaemons.go 63.57% <0.00%> (+1.51%) ⬆️
coderd/workspaceresources.go 60.97% <0.00%> (+1.62%) ⬆️
provisionersdk/transport.go 85.10% <0.00%> (+6.38%) ⬆️
coderd/parameter/compute.go 80.74% <0.00%> (+6.66%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 94ab6f3...c5f5c76. Read the comment docs.

Copy link
Contributor

@jsjoeio jsjoeio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for doing this! As Kyle said, this will make PRs a lot easier to read & review.

@presleyp presleyp merged commit 4c1ef38 into main Apr 8, 2022
@presleyp presleyp deleted the remove-annotations/presleyp branch April 8, 2022 19:57
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants