feat: Improve resource preview and first-time experience #946
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
kylecarbs
commented
Apr 10, 2022
- Adds resource preview table.
- Reorganizes prompts on workspace create.
- Improves english in various places.
This enables a "kubernetes_pod" to attach multiple agents that could be for multiple services. Each agent is required to have a unique name, so SSH syntax is: `coder ssh <workspace>.<agent>` A resource can have zero agents too, they aren't required.
This enables a "kubernetes_pod" to attach multiple agents that could be for multiple services. Each agent is required to have a unique name, so SSH syntax is: `coder ssh <workspace>.<agent>` A resource can have zero agents too, they aren't required.
This command was `true` by default, which causes a confusing user experience.
Codecov Report
@@ Coverage Diff @@
## main #946 +/- ##
==========================================
+ Coverage 66.22% 66.76% +0.54%
==========================================
Files 240 241 +1
Lines 14408 14582 +174
Branches 115 115
==========================================
+ Hits 9542 9736 +194
+ Misses 3904 3864 -40
- Partials 962 982 +20
Continue to review full report at Codecov.
|
greyscaled
reviewed
Apr 11, 2022
| @@ -17,7 +17,7 @@ const config: PlaywrightTestConfig = { | |||
| // https://playwright.dev/docs/test-advanced#launching-a-development-web-server-during-the-tests | |||
| webServer: { | |||
| // Run the coder daemon directly. | |||
| command: `go run -tags embed ${path.join(__dirname, "../../cmd/coder/main.go")} start --dev --tunnel=false`, | |||
| command: `go run -tags embed ${path.join(__dirname, "../../cmd/coder/main.go")} start --dev --skip-tunnel`, | |||
johnstcn
reviewed
Apr 11, 2022
agent/agent.go
Outdated
| @@ -100,6 +100,10 @@ func (a *agent) run(ctx context.Context) { | |||
| } | |||
|
|
|||
| func (a *agent) handlePeerConn(ctx context.Context, conn *peer.Conn) { | |||
| go func() { | |||
| <-a.closed | |||
There was a problem hiding this comment.
It feels strange to be doing this in one goroutine and waiting for conn.Closed() in another goroutine, just to call Done(). Can we not do it in one?
johnstcn
reviewed
Apr 11, 2022
johnstcn
reviewed
Apr 11, 2022
johnstcn
reviewed
Apr 11, 2022
johnstcn
reviewed
Apr 11, 2022
johnstcn
reviewed
Apr 11, 2022
johnstcn
reviewed
Apr 11, 2022
Co-authored-by: Cian Johnston <[email protected]>
johnstcn
reviewed
Apr 11, 2022
johnstcn
approved these changes
Apr 11, 2022
c3ba120 to
5f2d858
Compare
00a9994 to
421dd0e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.