Thanks to visit codestin.com
Credit goes to github.com

Skip to content

refactor: Improve handshake resiliency of peer #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 23 commits into from
Jan 31, 2022
Merged

refactor: Improve handshake resiliency of peer #95

Changes from 1 commit
Commits
Show all changes
23 commits
Select commit Hold shift + click to select a range
bf2f59f
fix: Synchronize peer logging with a channel
kylecarbs Jan 30, 2022
a8fe659
Merge branch 'main' into peerlog
kylecarbs Jan 30, 2022
aad88e0
Disable pion logging
kylecarbs Jan 30, 2022
59751f4
Remove buffer
kylecarbs Jan 30, 2022
107eb96
Try ICE servers
kylecarbs Jan 30, 2022
86cb3d4
Remove flushed
kylecarbs Jan 30, 2022
90d26f2
Add diagram explaining handshake
kylecarbs Jan 30, 2022
a5bd7e4
Fix candidate accept ordering
kylecarbs Jan 30, 2022
6528cdf
Add debug logging to peerbroker
kylecarbs Jan 30, 2022
b6003c7
Fix send ordering
kylecarbs Jan 30, 2022
7445f12
Lock adding ICE candidate
kylecarbs Jan 30, 2022
e155e31
Add test for negotiating out of order
kylecarbs Jan 30, 2022
65f378c
Reduce connection to a single negotiation channel
kylecarbs Jan 30, 2022
700afe4
Improve test times by pre-installing Terraform
kylecarbs Jan 30, 2022
7eccb81
Lock remote session description being applied
kylecarbs Jan 30, 2022
679e4aa
Organize conn
kylecarbs Jan 30, 2022
f20ce9d
Revert to multi-channel setup
kylecarbs Jan 30, 2022
09d8442
Properly close ICE gatherer
kylecarbs Jan 30, 2022
1facda9
Improve comments
kylecarbs Jan 30, 2022
f58a980
Try removing buffered candidates
kylecarbs Jan 30, 2022
b294481
Buffer local and remote messages
kylecarbs Jan 31, 2022
65c58c3
Log dTLS transport state
kylecarbs Jan 31, 2022
cd775ab
Add pion logging
kylecarbs Jan 31, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Add diagram explaining handshake
  • Loading branch information
@kylecarbs
kylecarbs committed Jan 30, 2022
commit 90d26f2a22d338b74a0ab590725c04baf429bba3
16 changes: 16 additions & 0 deletions peer/conn.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -288,6 +288,22 @@ func (*Conn) hashCandidate(iceCandidate webrtc.ICECandidateInit) string {
return fmt.Sprintf("%x", hash[:8])
}

// Negotiate exchanges ICECandidate pairs over the exposed channels.
// The diagram below shows the expected handshake. pion/webrtc v3
// uses trickle ICE by default. See: https://webrtchacks.com/trickle-ice/
// ┌────────┐ ┌────────┐
// │offerrer│ │answerer│
// │(client)│ │(server)│
// └─┬────┬─┘ └─┬──────┘
// │ │ offer │
// ┌──────────▼┐ ├──────────────►├──►┌───────────┐
// │STUN Server│ │ │ │STUN Server│
// │(optional) ├──►│ candidate │◄──┤(optional) │
// └───────────┘ │ (async) │ └───────────┘
// │◄─────────────►│
// │ │
// │ answer │
// └◄──────────────┘
func (c *Conn) negotiate() {
c.opts.Logger.Debug(context.Background(), "negotiating")

Expand Down