feat: Add support for VS Code and JetBrains Gateway via SSH #956
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This enables a "kubernetes_pod" to attach multiple agents that could be for multiple services. Each agent is required to have a unique name, so SSH syntax is: `coder ssh <workspace>.<agent>` A resource can have zero agents too, they aren't required.
This enables a "kubernetes_pod" to attach multiple agents that could be for multiple services. Each agent is required to have a unique name, so SSH syntax is: `coder ssh <workspace>.<agent>` A resource can have zero agents too, they aren't required.
This command was `true` by default, which causes a confusing user experience.
Codecov Report
@@ Coverage Diff @@
## main #956 +/- ##
==========================================
+ Coverage 66.55% 66.63% +0.07%
==========================================
Files 241 241
Lines 14582 14577 -5
Branches 115 115
==========================================
+ Hits 9705 9713 +8
+ Misses 3887 3881 -6
+ Partials 990 983 -7
Continue to review full report at Codecov.
|
This fixes various bugs that made this not work: - Incorrect max message size in `peer` - Incorrect reader buffer size in `peer` - Lack of SFTP support in `agent` - Lack of direct-tcpip support in `agent` - Misuse of command from session. It should always use the shell - Blocking on SSH session, only allowing one at a time Fixes #833 too.
f0ssel
approved these changes
Apr 11, 2022
johnstcn
reviewed
Apr 11, 2022
johnstcn
reviewed
Apr 11, 2022
johnstcn
approved these changes
Apr 11, 2022
421dd0e to
683f87e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes various bugs that made this not work:
peerpeeragentagentFixes #833 too.