feat: add support for networked provisioners #9593
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Spike Curtis <[email protected]>
Signed-off-by: Spike Curtis <[email protected]>
johnstcn
approved these changes
Sep 8, 2023
Comment on lines
+119
to
+148
| func GenCert() (*ecdsa.PrivateKey, []byte, error) { | ||
| privateKey, err := ecdsa.GenerateKey(elliptic.P256(), rand.Reader) | ||
| if err != nil { | ||
| return nil, nil, xerrors.Errorf("generate private key: %w", err) | ||
| } | ||
| template := x509.Certificate{ | ||
| SerialNumber: big.NewInt(1), | ||
| Subject: pkix.Name{ | ||
| CommonName: "Coder Provisioner Daemon", | ||
| }, | ||
| DNSNames: []string{serverName}, | ||
| NotBefore: time.Now(), | ||
| // cert is valid for 5 years, which is much longer than we expect this | ||
| // process to stay up. The idea is that the certificate is self-signed | ||
| // and is valid for as long as the daemon is up and starting new remote | ||
| // provisioners | ||
| NotAfter: time.Now().Add(time.Hour * 24 * 365 * 5), | ||
|
|
||
| KeyUsage: x509.KeyUsageKeyEncipherment | x509.KeyUsageDigitalSignature, | ||
| ExtKeyUsage: []x509.ExtKeyUsage{x509.ExtKeyUsageServerAuth}, | ||
| BasicConstraintsValid: true, | ||
| } | ||
|
|
||
| derBytes, err := x509.CreateCertificate(rand.Reader, &template, &template, &privateKey.PublicKey, privateKey) | ||
| if err != nil { | ||
| return nil, nil, xerrors.Errorf("failed to create certificate: %w", err) | ||
| } | ||
| cert := pem.EncodeToMemory(&pem.Block{Type: "CERTIFICATE", Bytes: derBytes}) | ||
| return privateKey, cert, nil | ||
| } |
There was a problem hiding this comment.
nit: there's a few more instances where we generate a self-signed cert, we could perhaps extract a util function here.
There was a problem hiding this comment.
I'm not convinced it would save much trouble once we account for all the variable arguments
| if !pt.Valid() { | ||
| go errResponse(job, respCh, xerrors.Errorf("invalid provisioner type: %s", job.Provisioner)) | ||
| } | ||
| tb := make([]byte, 4) // 128-bit token |
Signed-off-by: Spike Curtis <[email protected]>
Signed-off-by: Spike Curtis <[email protected]>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #9544
Adds support for (but does not enable) networked provisioners.