chore: display warnings on app share failure #9783
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Warnings only appear if the app is misconfigured to the deployment
mafredri
approved these changes
Sep 19, 2023
|
Can we also link the docs pages to the required flags? |
If I do that, I need to format the warnings in some way to include links. I do not want to pass HTML and render it. So passing a link requires some more infrastructure 😢 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Warnings only appear if the template is trying to do something the deployment has disabled. So it does leak the existance of an app, but only if the app is misconfigured. So this should be ok??
ownerrole app override disabled. Owners can access the apps from a RBAC perspective, but are denied in Golang from the deployment flag. So leaking this app info is ok.Closes: #9016
How it looks
We can improve styling later. @BrunoQuaresma
With 1 warning
No warnings looks the same as before.