feat(scaletest): add grafana annotations and slack reporting #9852
Conversation
| --count "${SCALETEST_PARAM_NUM_WORKSPACES}" \ | ||
| --template "${SCALETEST_PARAM_TEMPLATE}" \ | ||
| --concurrency "${SCALETEST_PARAM_CREATE_CONCURRENCY}" \ | ||
| --job-timeout 2h \ | ||
| --no-cleanup \ | ||
| --output json:"${SCALETEST_RESULTS_DIR}/create-workspaces.json" |
There was a problem hiding this comment.
nit: Since you're prefixing everything else with SCALETEST_PARAM_, perhaps also this one?
There was a problem hiding this comment.
I was thinking about them separately, one is params that a user can change (via template) and the other is plain variables used by the suite. Since all SCALETEST_PARAM_ prefixed vars are attached to reports in sorted order, this also gives us more control what to report/where.
| # shellcheck disable=SC2153 source=scaletest/templates/scaletest-runner/scripts/lib.sh | ||
| . "${SCRIPTS_DIR}/lib.sh" | ||
|
|
||
| # NOTE(mafredri): API returns HTML if we accidentally use `...//api` vs `.../api`. |
There was a problem hiding this comment.
👀 that sounds like a bug? (Edit: in coderd, I mean)
There was a problem hiding this comment.
We could consider it one. Funnily enough, Grafana has the same issue (you get page not found). 😄
| order = 25 | ||
| name = "Dashboard Traffic Duration" | ||
| type = "number" | ||
| description = "The duration of the dashboard traffic load scenario in minutes." |
There was a problem hiding this comment.
nit: alternatively, we could use a select box with predefined periods
There was a problem hiding this comment.
It's a good idea, perhaps once we have a better idea of what those predefined periods should be. 👍🏻
Fixes #9575
Fixes #9576