chore: fix storybook fonts #988
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Configures storybook with MUI themes as according to their documentation. We were previously not aligned with their example. See: https://storybook.js.org/addons/@react-theming/storybook-addon Details: - declare the themeing add-on in .storybook/main.js addons - configure a providerFn for MUI with CssBaseline. We were previously missing the CssBaseline implementation, causing the inconsistency. Impact: Resolves inconsistency between Storybook and production. I had tested the Tabpanel in production vs Storybook. In storybook, the font had fallen back to Times New Roman, whereas in production it had fallen back to Inter. This was because of CssBaseline being configured as a child of ThemeProvider. Resolves: #914
Codecov Report
@@ Coverage Diff @@
## main #988 +/- ##
==========================================
+ Coverage 66.53% 66.77% +0.23%
==========================================
Files 240 240
Lines 14588 14588
Branches 115 115
==========================================
+ Hits 9706 9741 +35
+ Misses 3892 3869 -23
+ Partials 990 978 -12
Continue to review full report at Codecov.
|
This comment was marked as resolved.
This comment was marked as resolved.
|
@presleyp I tagged you for review in https://www.chromatic.com/pullrequest?appId=624de63c6aacee003aa84340&number=988 I checked each diff here: https://www.chromatic.com/build?appId=624de63c6aacee003aa84340&number=308 it seems like in addition to typography being fixed in a few places (tabpanel, navbar), there were a few spacing changes. They seem fine to me (they're like this in prod). LMK if you spot anything concerning! |
presleyp
approved these changes
Apr 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary:
Configures storybook with MUI themes as according to their
documentation. We were previously not aligned with their example.
See: https://storybook.js.org/addons/@react-theming/storybook-addon
Details:
missing the CssBaseline implementation, causing the inconsistency.
Impact:
Resolves inconsistency between Storybook and production. I had tested
the Tabpanel in production vs Storybook. In storybook, the font had
fallen back to Times New Roman, whereas in production it had fallen back
to Inter. This was because of CssBaseline being configured as a child of
ThemeProvider.
Resolves: #914