Thanks to visit codestin.com
Credit goes to github.com

Skip to content

chore: fix storybook warnings #989

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 13, 2022

Conversation

greyscaled
Copy link
Contributor

Summary:

Just fixes some warnings caused by deprecations and inconsistent babel
configs.

Details:

Impact:

Clearer output from Storybook while developing

Resolves: #533

@greyscaled greyscaled requested a review from a team as a code owner April 13, 2022 03:35
@greyscaled greyscaled self-assigned this Apr 13, 2022
@codecov
Copy link

codecov bot commented Apr 13, 2022

Codecov Report

Merging #989 (ffeddc3) into main (ce49966) will increase coverage by 0.21%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main     #989      +/-   ##
==========================================
+ Coverage   66.53%   66.75%   +0.21%     
==========================================
  Files         240      240              
  Lines       14588    14588              
  Branches      115      115              
==========================================
+ Hits         9706     9738      +32     
+ Misses       3892     3865      -27     
+ Partials      990      985       -5     
Flag Coverage Δ
unittest-go-macos-latest 53.67% <ø> (+0.18%) ⬆️
unittest-go-postgres- 66.20% <ø> (-0.09%) ⬇️
unittest-go-ubuntu-latest 56.13% <ø> (-0.02%) ⬇️
unittest-go-windows-2022 52.93% <ø> (+0.05%) ⬆️
unittest-js 61.56% <ø> (ø)
Impacted Files Coverage Δ
peerbroker/proxy.go 57.55% <0.00%> (-0.59%) ⬇️
coderd/provisionerdaemons.go 62.95% <0.00%> (-0.52%) ⬇️
provisionerd/provisionerd.go 81.32% <0.00%> (+1.02%) ⬆️
coderd/workspaceagents.go 59.82% <0.00%> (+1.33%) ⬆️
peer/channel.go 87.86% <0.00%> (+2.31%) ⬆️
provisioner/echo/serve.go 56.80% <0.00%> (+2.39%) ⬆️
peer/conn.go 81.72% <0.00%> (+2.79%) ⬆️
pty/start_other.go 88.23% <0.00%> (+23.52%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ce49966...ffeddc3. Read the comment docs.

@greyscaled greyscaled enabled auto-merge (squash) April 13, 2022 03:45
@greyscaled greyscaled disabled auto-merge April 13, 2022 03:45
@greyscaled greyscaled enabled auto-merge (squash) April 13, 2022 03:45
@greyscaled greyscaled merged commit 5ecc823 into main Apr 13, 2022
@greyscaled greyscaled deleted the vapurrmaid/533/storybook-configuration branch April 13, 2022 16:03
@misskniss misskniss added this to the V2 Beta milestone May 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix verbose storybook warning
3 participants