fix: display offline workspaces #39
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This stack of pull requests is managed by Graphite. Learn more about stacking. |
f5fdeeb to
c1bc5ad
Compare
d434e77 to
024d7e3
Compare
a9e3504 to
caf84f1
Compare
ThomasK33
reviewed
Feb 11, 2025
caf84f1 to
ce1883e
Compare
ethanndickson
commented
Feb 12, 2025
Comment on lines
+19
to
+21
| // `.alert` from SwiftUI doesn't play nice when the calling view is in the | ||
| // menu bar. | ||
| private func showAlert() { |
There was a problem hiding this comment.
If you use .alert, the menu bar window dismisses itself, and takes the alert with it - it basically doesn't work at all.
This older NSAlert API creates a temporary, managed, window instead.
If we need to create popup alerts for something that's part of the normal user flow later, we'll need to find a better way.
ThomasK33
reviewed
Feb 12, 2025
| @Environment(\.dismiss) var dismiss | ||
| @EnvironmentObject var vpn: VPN | ||
| var msg: String { | ||
| "\(vpn.menuState.invalidAgents.count) invalid \(vpn.menuState.invalidAgents.count > 1 ? "agents" : "agent").." |
There was a problem hiding this comment.
Are we purposefully calling it an invalid agent or should we stick to invalid workspace?
There was a problem hiding this comment.
Good point. Let's stick with agent for now since this an internal error we're surfacing.
ThomasK33
approved these changes
Feb 12, 2025
7ffa48b
into
ethan/quarantine-workaround
3 of 4 checks passed
ethanndickson
added a commit
that referenced
this pull request
Feb 12, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The app previously didn't match the proposed design (and the Windows app) and display offline workspaces with a gray status.
Also improves the app's handling of invalid agents, indicating to the user that something went wrong. Clicking the button opens an alert with info. It's possible for invalid agents to resolve themselves, such as if the workspace update is sent at a later time.
Formatting these legacy API alert messages (such as to uncentre the text) is a pain, but ideally users never see these errors in the first place, so I think it's okay.
Also, for some reason I had the display of an agent in the list as always .coder. Whilst it usually is that value, if there's multiple agents in a workspace coderd will not send .coder as a FQDN, in which case we should instead display the next shortest FQDN, which we do now.