Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

fioan89
Copy link
Collaborator

@fioan89 fioan89 commented Aug 26, 2025

  • this commit add descriptive names to launched coroutines for better stack traces.
  • extra logging lines during connection setup. Should be helpful in cases where the coroutines
    fail with exceptions

This commit add descriptive names to launched coroutines for better stack traces.
SSH config manipulation is a heavy operation that involves disk writing and
can take long time. Logs are added so that we can easily identify when the ssh
configuration writing is done.
During plugin initialization we have a couple of steps that are only reported in the screen.
If there is any error happening in between the steps, it is hard to identify between which steps
things went wrong without a screenshots provided by the user.
@fioan89 fioan89 marked this pull request as ready for review August 26, 2025 22:58
Calling onBack() in the exception handler doesn't make sense because:

- the coroutine is already interrupted by the exception
- onBack() is meant to handle user-initiated back navigation, not error recovery
- we still want the proper navigation logic but without the coroutine cancellation part
@fioan89 fioan89 merged commit 22f53f6 into main Aug 28, 2025
6 checks passed
@fioan89 fioan89 deleted the impl-improve-diagnose branch August 28, 2025 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants