fix: don't store token when certificates are configured #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was a regression for the custom flows that required authentication via certificates, the http client and the coder cli were properly initialized but afterward the token was still required for storing. Note: the issue was hard to catch early on because the official coder cli is not supporting auth. via certificates.
Poll jobs now have a random friendly name that changes each time a new job is created, and the logging for when the jobs are created or cancelled is also improved. The idea behind this commit is to improve debugging sessions on client logs by: - having clear log lines saying when a job is created/destructed - easy to remember and cross-match job names (instead of cryptic java reference values)
Seems like we can't properly get the coroutine name from a Job. The name of the coroutine is not super friendly but still workable with the new logs.
code-asher
approved these changes
Sep 13, 2025
Yeap, it raised an error. Seems like the underlying store will not allow nu/empty values. |
|
Trippy! Ohhh and I thought a blank value would call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was a regression for the custom flows that required authentication via certificates, the http client and the coder cli were properly initialized but afterward the token was still required for storing.
Note: the issue was hard to catch early on because the official coder cli is not supporting auth. via certificates.