feat: style login redirect page - [ch1400] #221
Conversation
@alexgilev let me know what you think, feel free to blow it up. |
|
This pull request has been linked to Clubhouse Story #1400: coder login redirect page lacks any styling. |
|
@cmoog moved the template outside the control flow, also put it into a parameterized function after noticing another state needing to be expressed not specified in the ticket (a session_token missing). @rachelchhay put in your design suggestion (made it look like a power button) as well as lifted colors from our 2.0 scheme. Also notice the "off" state I added needed for a "session_token" missing state. 1400-on.mov1400-off.mov |
internal/loginsrv/server.go
Outdated
| func (srv *Server) ServeHTTP(w http.ResponseWriter, req *http.Request) { | ||
| ctx := req.Context() | ||
|
|
||
| token := req.URL.Query().Get("session_token") | ||
| if token == "" { | ||
| w.WriteHeader(http.StatusBadRequest) | ||
| _, _ = fmt.Fprintf(w, "No session_token found.\n") // Best effort. | ||
| // _, _ = fmt.Fprintf(w, "No session_token found.\n") // Best effort. |
There was a problem hiding this comment.
| // _, _ = fmt.Fprintf(w, "No session_token found.\n") // Best effort. |
|
@kvnlnt @rachelchhay @cmoog This is awesome stuff |
Adds basic styling to login redirect page.
1400-demo.mov
@vapurrmaid who else might I add as a reviewer?