chore: limit direct uses of os.Stdout/os.Stderr/os.Stdin #278

cmoog · 2021-03-10T19:40:29Z

By moving the out/err/in channels to the cobra config,
it will be easier to add fast and isolated unit tests.

By moving the out/err/in channels to the cobra config, it will be easier to add fast and isolated unit tests.

jawnsy

Sweet, LGTM 👍

chore: limit direct uses of os.Stdout/os.Stderr/os.Stdin

7f92bef

By moving the out/err/in channels to the cobra config, it will be easier to add fast and isolated unit tests.

cmoog requested a review from jawnsy March 10, 2021 19:40

jawnsy assigned cmoog Mar 10, 2021

jawnsy approved these changes Mar 10, 2021

View reviewed changes

cmoog merged commit bc391d9 into master Mar 10, 2021

cmoog deleted the cmoog/input-output branch March 10, 2021 19:51

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore: limit direct uses of os.Stdout/os.Stderr/os.Stdin #278

chore: limit direct uses of os.Stdout/os.Stderr/os.Stdin #278

Uh oh!

cmoog commented Mar 10, 2021

Uh oh!

jawnsy left a comment

Uh oh!

Uh oh!

chore: limit direct uses of os.Stdout/os.Stderr/os.Stdin #278

chore: limit direct uses of os.Stdout/os.Stderr/os.Stdin #278

Uh oh!

Conversation

cmoog commented Mar 10, 2021

Uh oh!

jawnsy left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!