This repository was archived by the owner on Aug 30, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 19
feature: support filtering by workspace provider when listing environ… #282
Merged
fuskovic
merged 6 commits into
master
from
faris/ch7505/add-provider-flag-to-coder-envs-ls
Mar 11, 2021
Merged
feature: support filtering by workspace provider when listing environ… #282
fuskovic
merged 6 commits into
master
from
faris/ch7505/add-provider-flag-to-coder-envs-ls
Mar 11, 2021
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ee4b8c7 to
e9874ea
Compare
cmoog
reviewed
Mar 11, 2021
cmoog
reviewed
Mar 11, 2021
cmoog
reviewed
Mar 11, 2021
Contributor
|
So I'm having second thoughts about this design. In all other cases |
cmoog
approved these changes
Mar 11, 2021
Contributor
cmoog
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great stuff. looks good to go
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this does?
Adds the
--providerflag to both thecoder envs lscommand as well as thecoder resources topcommand.envs command
Now supports the
--providerflag so users can filter environments by a particular workspace provider name.resource manager command
Now supports the
--providerflag so users can aggregate resource amounts by a particular workspace provider name.