This repository was archived by the owner on Aug 30, 2024. It is now read-only.
Warn if coder-cli is not in PATH on Windows #357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deansheather
commented
May 21, 2021
|
What's blocking this? Seems like it could be important for the |
|
@kylecarbs The package I'm using to check if the binary is in path seems to fail when cross-compiled for Windows from within my workspace, but works when I build on my Windows machine. I may just write my own function that does the same thing. |
5fa9eff to
3746bf5
Compare
|
It works when I remove |
kylecarbs
approved these changes
Jul 26, 2021
| @@ -212,7 +259,7 @@ func makeSSHConfig(binPath, host, userName, workspaceName, privateKeyFilepath st | |||
| host := fmt.Sprintf( | |||
| `Host coder.%s | |||
| HostName coder.%s | |||
| ProxyCommand %s tunnel %s 12213 stdio | |||
| ProxyCommand "%s" tunnel %s 12213 stdio | |||
There was a problem hiding this comment.
Do the quotes work on Linux too? I thought I tried it before...
There was a problem hiding this comment.
Works on windows, mac and linux from my testing.
|
This pull request has been linked to Clubhouse Story #15394: bug: escape path to coder-cli in .ssh/config. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Powershell and VS Code, the OpenSSH for Windows
ProxyCommandis expected to be a binary name likecoderor a Windows-like path such asC:\path\to\coder.exe.In Msys2 and Git Bash, the Linux-y OpenSSH expects the
ProxyCommandto be a binary name or a Unix-like path such as/c/path/to/coder.To support both environments simultaneously, the
ProxyCommandmust be set tocoder(or whatever binary name coder-cli has), and we must warn the user if the binary is not in$PATH.[CH-15394]