This repository was archived by the owner on Aug 30, 2024. It is now read-only.
feat: Add Closed func to Dialer #381
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deansheather
approved these changes
Jul 9, 2021
wsnet/dial_test.go
Outdated
| go func() { | ||
| _ = dialer.Close() | ||
| }() | ||
| <-dialer.Closed() |
There was a problem hiding this comment.
do a select against a timer here so we can ensure it closes quickly
wsnet/dial.go
Outdated
Comment on lines
143
to
146
| if !d.closed { | ||
| d.closed = true | ||
| close(d.closedChan) | ||
| } |
There was a problem hiding this comment.
Instead of having a bool have a select with a default:
select {
case <-d.closedChan:
return
default:
}
close(d.closedChan)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.