Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Aug 30, 2024. It is now read-only.

fix: use zero'd logger for Dial when no logger is passed #430

Merged
merged 1 commit into from
Sep 8, 2021
Merged

fix: use zero'd logger for Dial when no logger is passed #430

merged 1 commit into from
Sep 8, 2021

Conversation

coadler
Copy link
Contributor

@coadler coadler commented Sep 8, 2021

No description provided.

@coadler coadler requested a review from deansheather September 8, 2021 00:47
@coadler coadler self-assigned this Sep 8, 2021
@coadler coadler force-pushed the colin/fix-wsnet-logger branch from 31b55a0 to 2e17a2c Compare September 8, 2021 00:51
@coadler coadler enabled auto-merge (squash) September 8, 2021 00:52
@coveralls
Copy link

Pull Request Test Coverage Report for Build 1211512979

  • 0 of 1 (0.0%) changed or added relevant line in 1 file are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.03%) to 47.897%
Changes Missing Coverage Covered Lines Changed/Added Lines %
wsnet/dial.go 0 1 0.0%
Files with Coverage Reduction New Missed Lines %
wsnet/dial.go 2 77.39%
Totals Coverage Status
Change from base Build 1211386579: -0.03%
Covered Lines: 2790
Relevant Lines: 5825
💛 - Coveralls

@coadler coadler merged commit 795a283 into main Sep 8, 2021
@coadler coadler deleted the colin/fix-wsnet-logger branch September 8, 2021 00:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@deansheather deansheather deansheather approved these changes

Assignees

@coadler coadler

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@coadler @coveralls @deansheather