Thanks to visit codestin.com
Credit goes to github.com

Skip to content

ci: build and push image for main branch #222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jun 10, 2024
Merged

ci: build and push image for main branch #222

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
1beb7c7
ci: build and push image for `main` branch
matifali Jun 5, 2024
2dc2054
chore: update fetch-depth in CI workflow to get older tags
matifali Jun 5, 2024
990e64f
do not make envbuilder the default builder
matifali Jun 5, 2024
3b455a8
--load does not work for multiarch images
matifali Jun 5, 2024
5a969c7
only build amd64 when on PR
matifali Jun 5, 2024
ee51be3
Merge branch 'main' into build-main
matifali Jun 6, 2024
f5e11ec
Merge branch 'main' into build-main
johnstcn Jun 10, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
chore: update fetch-depth in CI workflow to get older tags
  • Loading branch information
@matifali
matifali committed Jun 5, 2024
commit 2dc20546043e52a21038bd16c04cbc747367b57c
3 changes: 3 additions & 0 deletions .github/workflows/ci.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -73,6 +73,9 @@ jobs:
steps:
- name: Checkout
uses: actions/checkout@v4
with:
# Needed to get older tags
fetch-depth: 0
Comment on lines +77 to +78
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we probably don't need the tags if we're just building a preview image on main?

Copy link
Member Author

@matifali matifali Jun 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. The benefit of the version tag is to use any previous image. It's a choice we should make. If we only tag with main then we will only have a single tagged image pointing to the tip of the main.


- uses: actions/setup-go@v5
with:
Expand Down