fix: always add COPY directives in DoCacheProbe #293
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnstcn
commented
Aug 2, 2024
| @@ -485,6 +497,9 @@ func (o *Options) Markdown() string { | |||
| _, _ = sb.WriteString("| - | - | - | - |\n") | |||
|
|
|||
| for _, opt := range cliOptions { | |||
| if opt.Hidden { | |||
There was a problem hiding this comment.
review: drive-by; I don't think hidden options should be documented.
mafredri
approved these changes
Aug 2, 2024
johnstcn
added a commit
that referenced
this pull request
Aug 5, 2024
(cherry picked from commit 065bcaa)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required in order to correctly handle RunCacheProbe. Without it, we will be unable to correctly detect the final layer of the built image.