feat: allow for configurable ignore paths #33
Conversation
This resolves coder/coder#8540.
envbuilder.go
Outdated
| options.WorkspaceFolder, | ||
| // Required for devcontainer to ignore directories like /var/run/secrets, | ||
| // which frequently has mounted read-only runtime secrets. | ||
| "/var/run", |
There was a problem hiding this comment.
Does this mean files added to /var/run won't be snapshotted? I think that's probably okay in most cases, but might be confusing if someone actually wants to build those files into the container image. Maybe a configurable ignore list would be best?
There was a problem hiding this comment.
I'm changing this to /var/run/secrets instead to get closer to the actual problem, and it will become a configurable ignore array in the future that allows users to improve caching without us promoting a bespoke filesystem format.
There was a problem hiding this comment.
Hmm, seems like I actually can't make it be a nested dir because it attempts to remove /var/run. I'm going to make this configurable now to save us some headaches.
There was a problem hiding this comment.
It's now configurable! Thanks for the feedback 🥳
This resolves coder/coder#8540.