Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix(envbuilder.go)!: rename MagicDirBase CLI option #389

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 22, 2024
Merged

fix(envbuilder.go)!: rename MagicDirBase CLI option #389

merged 1 commit into from
Oct 22, 2024

Conversation

SasSwart
Copy link
Contributor

This PR is a breaking change!
It renames a publicly accessible CLI option referenced in #184.
It should not be merged into release/1.0 as this would break at least the terraform provider that relies on this option.

This commit may be cherry-picked into release/2.0 when that branch is created.

This PR closes #184.

@SasSwart SasSwart requested a review from johnstcn October 15, 2024 11:18
@SasSwart SasSwart marked this pull request as ready for review October 15, 2024 11:18
@johnstcn johnstcn requested a review from mafredri October 15, 2024 11:19
@johnstcn
Copy link
Member

johnstcn commented Oct 15, 2024 •
edited
Loading

@mafredri Are you happy with us merging this to main now? Or would you like to defer this to a later date so we don't end up needing to do too many backport changes?

@mafredri
Copy link
Member

@mafredri Are you happy with us merging this to main now? Or would you like to defer this to a later date so we don't end up needing to do too many backport changes?

(We could just make it backwards compatible for a period of time by including the old property (and checking it too) but marking it deprecated. That way we’re not in a rush to sync the changes to the provider.)

I’m also fine with merging as-is, but I’d avoid cherry-picking it into release/1.0 unless there are conflicts. Our next non-patch release should be release/1.1, which we branch out from main, and I think it’s fine to include this there.

@SasSwart SasSwart merged commit 58ac15f into main Oct 22, 2024
4 checks passed
@SasSwart SasSwart deleted the jjs/184-1 branch October 22, 2024 12:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mafredri mafredri mafredri approved these changes

@johnstcn johnstcn Awaiting requested review from johnstcn

Assignees

@SasSwart SasSwart

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

rename envbuilder.MagicDir to envbuilder.WorkingDir
3 participants
@SasSwart @johnstcn @mafredri