Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Conversation

johnstcn
Copy link
Member

Modifies integration tests to reference a local devcontainer feature.
This removes the dependency on an external feature and lets us test more interesting things!

@johnstcn johnstcn self-assigned this Dec 18, 2024
@johnstcn johnstcn requested a review from mafredri December 18, 2024 12:48
Copy link
Member

@mafredri mafredri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, nice work!

t.Parallel()

ctx, cancel := context.WithCancel(context.Background())
t.Cleanup(cancel)

srv := gittest.CreateGitServer(t, gittest.Options{
Files: map[string]string{
// NOTE(mafredri): We can't cache the feature in our local
// registry because the image media type is incompatible.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for figuring this out! ❤️

Co-authored-by: Mathias Fredriksson <[email protected]>
@johnstcn johnstcn merged commit 1ab3f69 into main Dec 19, 2024
4 checks passed
@johnstcn johnstcn deleted the cj/local-devcontainer-feature branch December 19, 2024 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants