Thanks to visit codestin.com
Credit goes to github.com

Skip to content

fix: remove bottle :unneeded #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 1, 2021
Merged

fix: remove bottle :unneeded #26

merged 1 commit into from
Nov 1, 2021

Conversation

jsjoeio
Copy link
Contributor

@jsjoeio jsjoeio commented Oct 29, 2021

This PR fixes a warning issued by Homebrew when users use the coder or coder-nightly CLI.

Warning: Calling bottle :unneeded is deprecated! There is no replacement.
Please report this issue to the cdr/coder tap (not Homebrew/brew or Homebrew/core):
/usr/local/Homebrew/Library/Taps/cdr/homebrew-coder/coder-cli.rb:5

@jsjoeio jsjoeio self-assigned this Oct 29, 2021
@jsjoeio jsjoeio added the bug Something isn't working label Oct 29, 2021
@jsjoeio jsjoeio requested a review from deansheather October 29, 2021 18:13
@jsjoeio jsjoeio marked this pull request as ready for review October 29, 2021 18:13
@jsjoeio jsjoeio merged commit abc8e01 into master Nov 1, 2021
@jsjoeio jsjoeio deleted the jsjoeio-fix-bottle branch November 1, 2021 17:25
@jsjoeio
Copy link
Contributor Author

jsjoeio commented Nov 1, 2021

@deansheather not sure if we need to do a new release or something. lmk! (first time contributing here so not familiar with build/release process)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@deansheather deansheather deansheather approved these changes

Assignees

@jsjoeio jsjoeio

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsjoeio @deansheather