Thanks to visit codestin.com
Credit goes to github.com

Skip to content

flake: TestExpiredLeaseIsRequeued #121

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
spikecurtis opened this issue Oct 23, 2024 · 0 comments · Fixed by coder/coder#15186
Closed

flake: TestExpiredLeaseIsRequeued #121

spikecurtis opened this issue Oct 23, 2024 · 0 comments · Fixed by coder/coder#15186
Assignees
@spikecurtis
Labels
flake

Comments

@spikecurtis
Copy link 

    t.go:99: 2024-10-22 12:48:54.860 [warn]  manager: exiting ungracefully  error="context canceled"
    t.go:108: 2024-10-22 12:48:54.863 [erro]  manager.notifier: failed to fetch app name  notifier_id=1b1be80c-5f51-4b15-af76-ac9a5247262c ...
        error= get application name:
                   github.com/coder/coder/v2/coderd/notifications.(*notifier).fetchAppName
                       /home/runner/work/coder/coder/coderd/notifications/fetcher.go:43
                 - pq: canceling statement due to user request
         *** slogtest: log detected at level ERROR; TEST FAILURE ***

seen on: https://github.com/coder/coder/runs/31887276739
@spikecurtis spikecurtis mentioned this issue Oct 23, 2024
Merged
spikecurtis added a commit to coder/coder that referenced this issue Oct 25, 2024
@spikecurtis
fix: stop logging errors on cancel in notifier (#15186)
d9f1aaf 
fixes coder/internal#121

We shouldn't log errors when context is canceled, e.g. on shutdown.  This breaks our tests and alarms customers needlessly.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@spikecurtis spikecurtis

Labels
flake
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: stop logging errors on cancel in notifier coder/coder
2 participants
@spikecurtis @defelmnq