Closed
Description
Seen on main in https://github.com/coder/coder/actions/runs/11900586976/job/33161756273
Looks to be caused by pipeDialer, if the Dial function is called after the test has finished, one of the dial steps will somehow fail, and cause the no error assertion to fail. (The whole function looks self-contained, so I'm not sure how this is happening)
=== FAIL: tailnet TestInMemoryCoordination (unknown)
panic: Fail in goroutine after TestController_Disconnects has completed
goroutine 246 [running]:
testing.(*common).Fail(0xc0004c2b60)
/opt/hostedtoolcache/go/1.22.8/x64/src/testing/testing.go:952 +0xd4
testing.(*common).Errorf(0xc0004c2b60, {0x1a97734?, 0x411c25?}, {0xc00069e250?, 0x1751ba0?, 0x101?})
/opt/hostedtoolcache/go/1.22.8/x64/src/testing/testing.go:1075 +0x5e
github.com/stretchr/testify/assert.Fail({0x1d435c0, 0xc0004c2b60}, {0xc000646060, 0x2b}, {0x0, 0x0, 0x0})
/home/runner/go/pkg/mod/github.com/stretchr/[email protected]/assert/assertions.go:363 +0x370
github.com/stretchr/testify/assert.NoError({0x1d435c0, 0xc0004c2b60}, {0x1d43500, 0xc0002dedc0}, {0x0, 0x0, 0x0})
/home/runner/go/pkg/mod/github.com/stretchr/[email protected]/assert/assertions.go:1545 +0x125
github.com/coder/coder/v2/tailnet_test.(*pipeDialer).Dial(0xc000143800, {0xc0000ba230?, 0x1?}, {0x1aca93d?, 0x1f?})
/home/runner/work/coder/coder/tailnet/controllers_test.go:1223 +0x27c
github.com/coder/coder/v2/tailnet.(*Controller).Run.func1()
/home/runner/work/coder/coder/tailnet/controllers.go:1166 +0x139
created by github.com/coder/coder/v2/tailnet.(*Controller).Run in goroutine 84
/home/runner/work/coder/coder/tailnet/controllers.go:1161 +0x109