Thanks to visit codestin.com
Credit goes to github.com

Skip to content

User with site wide template admin or auditor role cannot access members for an org they are not a member of #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jaaydenh opened this issue Feb 19, 2025 · 1 comment · Fixed by coder/coder#16733
Closed

User with site wide template admin or auditor role cannot access members for an org they are not a member of #388

jaaydenh opened this issue Feb 19, 2025 · 1 comment · Fixed by coder/coder#16733
Assignees
@jaaydenh

Comments

@jaaydenh
Copy link

Expected:
A site-wide template admin or auditor should be able to access the members for an organizations they are not a member of.

Actual:
An server side error is displayed

Image
@aslilac
Copy link
Member

aslilac commented Feb 26, 2025 •
edited
Loading

template admins and auditors both definitely have organization_members.read so there's something weird going on here. maybe in the join with the groups query this page does? but they have group_members.read too.

I think this is probably more complicated than it seems, or at least not obvious.

@jaaydenh jaaydenh mentioned this issue Feb 27, 2025
Merged
jaaydenh added a commit to coder/coder that referenced this issue Feb 27, 2025
@jaaydenh
fix: add org role read permissions to site wide template admins and a…
bf5b002 
…uditors (#16733)

resolves coder/internal#388

Since site-wide admins and auditors are able to access the members page
of any org, they should have read access to org roles
aslilac pushed a commit to coder/coder that referenced this issue Feb 27, 2025
@jaaydenh @aslilac
fix: add org role read permissions to site wide template admins and a…
98ae4a5 
…uditors (#16733)

resolves coder/internal#388

Since site-wide admins and auditors are able to access the members page
of any org, they should have read access to org roles
gcp-cherry-pick-bot bot pushed a commit to coder/coder that referenced this issue Mar 3, 2025
@jaaydenh
fix: add org role read permissions to site wide template admins and a…
c6fcc64 
…uditors (#16733)

resolves coder/internal#388

Since site-wide admins and auditors are able to access the members page
of any org, they should have read access to org roles
@gcp-cherry-pick-bot gcp-cherry-pick-bot bot mentioned this issue Mar 3, 2025
Merged
stirby pushed a commit to coder/coder that referenced this issue Mar 4, 2025
@gcp-cherry-pick-bot @jaaydenh
fix: add org role read perm to site template admins and auditors (che…
a5eb06e 
…rry-pick #16733) (#16787)

Cherry-picked fix: add org role read permissions to site wide template
admins and auditors (#16733)

resolves coder/internal#388

Since site-wide admins and auditors are able to access the members page
of any org, they should have read access to org roles

Co-authored-by: Jaayden Halko <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jaaydenh jaaydenh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: add org role read permissions to site wide template admins and auditors coder/coder
2 participants
@aslilac @jaaydenh